SipsOfCode/infrastructure
2
2
Fork 0
Code Issues 5 Pull requests 4 Releases Activity

Fix ansible inventory path & allow custom roles #132

Merged
saibotk merged 1 commit from inventory-config-fixes into main 2025-07-19 18:09:52 +02:00
Conversation 3 Commits 1 Files changed 2 +5 -5
saibotk commented 2025-03-29 20:51:33 +01:00
Owner
Copy link

See commit messages & changes for detailed descriptions :)

With this i could finally move all my code to the inventory path.

See commit messages & changes for detailed descriptions :) With this i could finally move all my code to the inventory path.
saibotk self-assigned this 2025-03-29 20:51:33 +01:00 
The inventory folders contain the actual inventory folder now.
So we had to adjust the paths to point to the inner directory.
Otherwise ansible tries to interpret every file in the directory
as an inventory ini file and shows warnings.
feat(ansible): Include custom roles from inventory
All checks were successful
ci/woodpecker/pr/ansible-lint Pipeline was successful
Details
c2dae1c551
 
We added the inventory/roles path to the roles path to allow
custom private roles inside the inventory folder.
requested review from histalek 2025-03-29 20:51:37 +01:00
histalek requested changes 2025-03-30 08:03:40 +02:00
Dismissed
histalek left a comment
Owner
Copy link

Interesting, this works even better than my approach.

But with this the upper directories are named somewhat confusing. Should we move these to private/ and sips/ ? That would also need changes to the .gitignore

Interesting, this works even better than my approach. But with this the upper directories are named somewhat confusing. Should we move these to `private/` and `sips/` ? That would also need changes to the .gitignore
saibotk commented 2025-03-30 12:52:06 +02:00
Author
Owner
Copy link

Sure i'll push another commit

Sure i'll push another commit
refactor(ansible): move inventories to config_ dirs
All checks were successful
ci/woodpecker/pr/ansible-lint Pipeline was successful
Details
ci/woodpecker/push/ansible-lint Pipeline was successful
Details
dbe90c9381
 
This allows them to be ordered together in the file tree and the naming is much clearer now.
requested review from histalek 2025-03-30 12:59:23 +02:00
saibotk changed title from Fix Anisible inventory path & allow custom roles to Fix ansible inventory path & allow custom roles 2025-03-30 13:06:54 +02:00
histalek approved these changes 2025-03-30 13:53:13 +02:00
histalek left a comment
Owner
Copy link

LGTM

LGTM
saibotk deleted branch inventory-config-fixes 2025-03-30 14:21:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
histalek
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
saibotk
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SipsOfCode/infrastructure#132
No description provided.
Delete branch "inventory-config-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?